Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 11, 2025

Description

Dashboard__Otlp__SuppressUnsecuredTelemetryMessage was added in 9.5.1(?)

Dashboard__Otlp__SuppressUnsecuredMessage is the new name in v13 (old name still works!) to be consistent with Dashboard__Mcp__SuppressUnsecuredMessage

This PR changes AzureAppService intergration to use the new config name.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK requested review from Copilot and davidfowl November 11, 2025 00:21
@JamesNK JamesNK added the area-integrations Issues pertaining to Aspire Integrations packages label Nov 11, 2025
@JamesNK JamesNK requested a review from eerhardt as a code owner November 11, 2025 00:21
@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12878

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12878"

Copilot finished reviewing on behalf of JamesNK November 11, 2025 00:23
@JamesNK JamesNK changed the title Update AzureAppService integration to set new suppress configuration Update AzureAppService integration to set new suppress configuration name Nov 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the AzureAppService integration to use the new, simplified configuration name Dashboard__Otlp__SuppressUnsecuredMessage instead of the older Dashboard__Otlp__SuppressUnsecuredTelemetryMessage. The new name is consistent with the similar MCP configuration Dashboard__Mcp__SuppressUnsecuredMessage. Backward compatibility is maintained by keeping the old name as a legacy configuration option.

Key Changes

  • Updated configuration name to align with naming conventions across Dashboard settings
  • Maintained backward compatibility for the old configuration name
  • Updated all test snapshots and playground files to reflect the new configuration name

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentUtility.cs Updated app settings to use new Dashboard__Otlp__SuppressUnsecuredMessage configuration name
src/Shared/DashboardConfigNames.cs Removed old non-legacy config name and updated legacy config name to use proper naming suffix and environment variable format
src/Aspire.Dashboard/Configuration/PostConfigureDashboardOptions.cs Updated reference to use the corrected legacy config name property
tests/Aspire.Dashboard.Tests/DashboardOptionsTests.cs Updated test to use the corrected legacy config name property
tests/Aspire.Hosting.Azure.Tests/Snapshots/*.verified.bicep Updated snapshot files to reflect new configuration name in generated Bicep templates
playground/AzureAppService/AzureAppService.AppHost/infra.module.bicep Updated playground infrastructure to use new configuration name

@eerhardt
Copy link
Member

FYI @ShilpiRach

dashboard.SiteConfig.AppSettings.Add(new AppServiceNameValuePair { Name = "Dashboard__Frontend__AuthMode", Value = "Unsecured" });
dashboard.SiteConfig.AppSettings.Add(new AppServiceNameValuePair { Name = "Dashboard__Otlp__AuthMode", Value = "Unsecured" });
dashboard.SiteConfig.AppSettings.Add(new AppServiceNameValuePair { Name = "Dashboard__Otlp__SuppressUnsecuredTelemetryMessage", Value = "true" });
dashboard.SiteConfig.AppSettings.Add(new AppServiceNameValuePair { Name = "Dashboard__Otlp__SuppressUnsecuredMessage", Value = "true" });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we need to be careful of is that Azure AppService is not updated to the latest dashboard at all times. It takes a while. Currently, it is using 9.5.2 in Azure. So if we merged this, it will break for anyone using main builds.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will it be safe to change? Merging now would make this change for 13.1. Should it wait a release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShilpiRach - thoughts?

I think AppService is waiting on us producing a 13.0 dashboard docker image. And then it would need to roll that out to all AppService regions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-integrations Issues pertaining to Aspire Integrations packages azure-app-service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants