-
Notifications
You must be signed in to change notification settings - Fork 739
Fix subscription ID not being disabled on Azure provisioning dialog #12888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12888Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12888" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where the subscription ID input field was not properly disabled when there's no pre-configured subscription ID. The issue was introduced in PR #12172 which added tenant ID selection.
Key changes:
- Conditional creation of
InputLoadOptionsfor subscription ID (only when not pre-configured) - Always initialize subscription ID input as disabled
- Removed redundant null check inside the
LoadCallback
|
Does this preserve when the subscription is already set from config? (Which means the tenant isn’t required) |
|
I think so. The changes are minor (listed in PR body). I would test, but I don't know how to get just a SubscriptionId preset but still have the dialog pop up. |
|
Set Azure:SubscriptionId in your config |
|
I believe I've fixed both scenarios. Please double check. |
| .interaction-input-dialog .interaction-input ::deep fluent-select, | ||
| .interaction-input-dialog .interaction-input ::deep fluent-combobox { | ||
| .interaction-input-dialog .interaction-input ::deep fluent-combobox, | ||
| .interaction-input-dialog .interaction-input ::deep label { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated. Label width not being the same as input has bugged me
|
/backport to release/13.0 |
|
Started backporting to release/13.0: https://github.com/dotnet/aspire/actions/runs/19281772994 |
Co-authored-by: JamesNK <[email protected]>
Co-authored-by: JamesNK <[email protected]>

Description
PR #12172 added a new tenant ID option. However, if there is no subscription ID then the choice input is left enabled.
PR changes:
Fixes #12882
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate