remove --pre-release flag from extension official build #12897
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12897Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12897" |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the --pre-release flag from the VS Code extension packaging command for official builds, transitioning the extension from pre-release to stable release status.
Key Changes
- Removes
--pre-releaseflag from thevsce packagecommand in Extension.proj
|
|
||
| <!-- Package extension --> | ||
| <Exec Command="vsce package --pre-release --out $(ArtifactsPackagesDir)\vscode\aspire-vscode-$(_ExtractedVersion).vsix" | ||
| <Exec Command="vsce package --out $(ArtifactsPackagesDir)\vscode\aspire-vscode-$(_ExtractedVersion).vsix" |
There was a problem hiding this comment.
The --pre-release flag is being removed from the official build, but .github/workflows/tests.yml line 194 still packages the extension with --pre-release flag during extension tests. This inconsistency could lead to differences between test artifacts and production builds. Consider updating the test workflow to match this change for consistency.
There was a problem hiding this comment.
That distinction is intentional.
2 participants
No description provided.