Skip to content

Conversation

@adamint
Copy link
Member

@adamint adamint commented Nov 12, 2025

Description

This can be reenabled after a security review of the extension DCP server implementation of GHCP endpoints.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@adamint adamint requested a review from mitchdenny November 12, 2025 01:57
@adamint adamint self-assigned this Nov 12, 2025
Copilot AI review requested due to automatic review settings November 12, 2025 01:57
@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12917

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12917"

Copilot finished reviewing on behalf of adamint November 12, 2025 01:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily disables the GitHub Copilot integration in the Aspire dashboard when the application is launched through the VS Code extension, pending security review of the extension's DCP server implementation.

Key Changes:

  • Sets the ASPIRE_DASHBOARD_AI_DISABLED environment variable when launching apphosts
  • Bumps the extension version from 1.0.2 to 1.0.3

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
extension/src/debugger/languages/dotnet.ts Adds logic to set ASPIRE_DASHBOARD_AI_DISABLED=true environment variable when isApphost is true
extension/package.json Bumps extension version from 1.0.2 to 1.0.3 for the new feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant