Improvements to the M5 Stack Sample #2392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SentenceCache now forgets about object that are too old.
Otherwise, the project can only build against previous package version in release mode.
krwq
reviewed
May 29, 2025
krwq
reviewed
May 29, 2025
| [Option("nosleep", Default = false, HelpText = "Do not send the device to sleep when process terminates")] | ||
| public bool NoSleep { get; set; } | ||
|
|
||
| [Option("flipscreen", Default = false, HelpText = "Rotates the screen by 180 degrees")] |
Member
There was a problem hiding this comment.
is this rotating or mirroring? name suggests mirror
Contributor
Author
There was a problem hiding this comment.
It turns it upside-down.
krwq
reviewed
May 29, 2025
Co-authored-by: Krzysztof Wicher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SentenceCache now also "forgets" about messages that
are too old.
Plus a set of various bugfixes.
Microsoft Reviewers: Open in CodeFlow