Create replacement for now lacking physical-to-logical pin mapping #2435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
area-device-bindings
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new VirtualGpioControllerWithDefault class to support physical-to-logical pin mapping for GPIO controllers, specifically addressing the need for Raspberry Pi physical pin numbering. The implementation allows dynamic pin mapping through a default controller and a mapping function, replacing previous approaches that lacked this capability.
- Adds
VirtualGpioControllerWithDefaultclass extendingVirtualGpioControllerwith default controller support - Implements physical-to-logical pin mapping for Raspberry Pi boards via
ConvertPinNumberFromPhysicalToLogical - Updates
VirtualGpioController.OpenPinCoredocumentation to guide users toward the new alternative
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/devices/Board/VirtualGpioControllerWithDefault.cs | New class providing virtual GPIO controller with default controller and pin mapping function |
| src/devices/Board/VirtualGpioController.cs | Updated documentation for OpenPinCore to reference new alternative implementation |
| src/devices/Board/RaspberryPiBoard.cs | Added methods to create physical pin mapping and conversion logic from physical to logical numbering |
Should check the weird numbering of the OrangePi devices. Neither the "logical" nor the "physical" mapping match with the pin count, and the translation is unconditional.
Since these were only used when PinNumberingScheme == Physical, it was now unreachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow