Fix null reference crash in CheckUnderspecifiedGenericExtension for namespace-level extensions #80929
Conversation
…ce-level extensions Co-authored-by: jcouv <[email protected]>
jcouv
added
Area-Compilers
Feature - Extension Everything
|
|
||
| NamedTypeSymbol extension = extensionMember.ContainingType; | ||
| if (extension.ExtensionParameter is not { } extensionParameter || extension.ContainingType.Arity != 0) | ||
| if (extension.ExtensionParameter is not { } extensionParameter || extension.ContainingType?.Arity != 0) |
There was a problem hiding this comment.
I checked usages of ContainingType in context of usages of GetIsNewExtensionMember, ExtensionParameter and IsExtension.
I didn't find any problem, but added a couple of tests to ensure the null checks are covered.
There was a problem hiding this comment.
I checked usages of
ContainingTypein context of usages ofGetIsNewExtensionMember,ExtensionParameterandIsExtension. I didn't find any problem, but added a couple of tests to ensure the null checks are covered.
I thought GetIsNewExtensionMember got renamed. Did you use new name for the check?
There was a problem hiding this comment.
The PR was forked before the rename. I refreshed the PR and took another look (now for IsExtensionBlockMember()). Thanks
There was a problem hiding this comment.
FWIW, for other APIs, I don't think it's worthwhile to do another pass. We didn't change extension logic that much in the last 3 weeks.
|
Done with review pass (commit 3) #Closed |
|
Done with review pass (commit 4) |
…erspecified-generic-extension
Fixes #80829