[release/9.0-staging] Update dependencies from dotnet/roslyn #121343
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…915.8 On relative base path root Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.25467.18 -> To Version 4.14.0-3.25465.8 Microsoft.CodeAnalysis.Analyzers From Version 3.11.0-beta1.25173.3 -> To Version 3.12.0-beta1.25465.8
|
Failures with /cc @jeffhandley |
|
@copilot fix the error: |
…121414) The Roslyn 4.14.0 compiler update introduced stricter type checking for `MemoryMarshal.Cast` when called directly on arrays, now returning `ReadOnlySpan<T>` instead of `Span<T>`. ## Changes - **JsonDocument.MetadataDb.cs**: Explicitly convert byte array to `Span<byte>` before casting to `Span<int>` to preserve write access ```csharp // Before Span<int> newDbInts = MemoryMarshal.Cast<byte, int>(newDatabase); // After Span<int> newDbInts = MemoryMarshal.Cast<byte, int>(newDatabase.AsSpan()); ``` The writable span is required since the code modifies elements via `newDbInts[i] -= locationOffset`. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: sbomer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn