Make a test scenario less stressful. #121356
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/gc |
VSadov
force-pushed
the
fix119187
branch
2 times, most recently
from
ee575f7 to
a50dd1d
Compare
3 tasks
Member
Author
|
I've rebased/rerun the CI on this PR several times and did not see the issue reproducing. I think this is a sufficient fix for the test issue. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the reliability and performance of the TestAnotherThread test method in the GC.GetTotalAllocatedBytes test suite.
- Adds an upper bound to the background task's loop to prevent potential infinite loops
- Reduces main thread iterations from 1000 to 100 for faster test execution while maintaining adequate coverage
- Maintains early termination capability when the test completes
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test-only fix.
Fixes: #119187
The testcase creates and joins threads in a loop while another thread calls
GetTotalAllocatedBytesand checks various invariants: if the result is not negative, grows over time, ...This is not a stress test. The purpose is just to demonstrate that
GetTotalAllocatedBytesworks in the presence of threads starting and exiting. It does not need to run for very long.Creating/joining threads nonstop appear to cause issues on arm32. Sometimes we see OOMs.
In particular there is a concern that the thread that creates threads + the actual threads may starve the main thread, thus arbitrarily prolonging the scenario.
Thie fix tries to limit the total number of threads that the test creates, making its completion more deterministic.