Don't cast the pointer type for delete

[jkoritzinsky]

This was causing asan errors.

Fixes #121339

[Copilot]

Pull Request Overview

This PR removes an unnecessary C-style cast when deleting a USynchCacheStackNode pointer in the Add method of the CSynchCache template class.

Key Changes:

• Simplified the delete operation by removing the (char *) cast in the Add method, making the code cleaner and type-safe.

Comments suppressed due to low confidence (1)

src/coreclr/pal/src/include/pal/synchcache.hpp:181

• The Flush method on line 181 still uses the same C-style cast pattern delete (char *)pTemp; that was just removed from line 156. For consistency and type safety, this should also be changed to delete pTemp; since pTemp is already a USynchCacheStackNode * pointer allocated with new USynchCacheStackNode().

                delete (char *)pTemp;

[jkotas]

/ba-g Android timeouts