Skip to content

Conversation

@javiercn
Copy link
Member

  • Adds a benchmark project so that we can start adding benchmarks for some of the tasks

Copilot AI review requested due to automatic review settings June 20, 2025 13:22
@javiercn javiercn requested a review from a team as a code owner June 20, 2025 13:22
@github-actions github-actions bot added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch label Jun 20, 2025
@dotnet-policy-service
Copy link
Contributor

Thanks for your PR, @@javiercn.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces benchmarking infrastructure for the StaticWebAssets SDK by adding a new benchmark project and wiring it into the solution and package management.

  • Adds a console entry point and empty benchmark using BenchmarkDotNet
  • Sets up a dedicated benchmarks project with templates and ignores
  • Updates solution files and central package versions to include BenchmarkDotNet

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/StaticWebAssetsSdk/benchmarks/Program.cs Entry point to run all benchmarks
src/StaticWebAssetsSdk/benchmarks/Microsoft.NET.Sdk.StaticWebAssets.Benchmarks.csproj Benchmark project setup
src/StaticWebAssetsSdk/benchmarks/EmptyBenchmark.cs Initial no-op benchmark
src/StaticWebAssetsSdk/benchmarks/Directory.Build.template Empty build template copied to props/targets
src/StaticWebAssetsSdk/benchmarks/.gitignore Ignore BenchmarkDotNet artifacts
src/RazorSdk/Razor.slnf Included benchmark project in solution filter
sdk.slnx Added benchmarks folder to solution structure
eng/Versions.props Defined BenchmarkDotNet package version
Directory.Packages.props Centralized BenchmarkDotNet package version
Comments suppressed due to low confidence (1)

src/StaticWebAssetsSdk/benchmarks/Microsoft.NET.Sdk.StaticWebAssets.Benchmarks.csproj:4

  • Verify that the TargetFramework 'net10.0' is supported by our build environment. If not, consider targeting a stable TFM like net7.0 or net8.0 to ensure compatibility.
    <TargetFramework>net10.0</TargetFramework>

@javiercn javiercn requested review from MackinnonBuck and maraf June 23, 2025 09:55
javiercn and others added 3 commits June 23, 2025 16:11
@javiercn javiercn force-pushed the javiercn/add-benchmark-project branch from 68fefb5 to e0362b2 Compare June 23, 2025 14:11
@javiercn javiercn merged commit 639cdb1 into main Jun 23, 2025
31 checks passed
@javiercn javiercn deleted the javiercn/add-benchmark-project branch June 23, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants