Stop bundling obsolete FSharp.NET.SDK #51650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for the obsolete FSharp.NET.SDK package which is no longer needed, as referenced in issue #48818. The changes simplify the build configuration by removing conditional logic that detected and accommodated the old SDK.
- Simplified FSharp props configuration by removing conditional detection of FSharp.NET.Sdk properties
- Removed FSharp.NET.Sdk from the list of bundled SDKs
- Removed FSharp.NET.Sdk from Stage0 SDK file inclusions used in performance tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FSharp.props | Removed conditional logic that detected FSharp.NET.Sdk-specific properties and simplified PropertyGroup to always set UseBundledFSharpTargets to true by default |
| src/Tasks/Microsoft.NET.Build.Tasks/Microsoft.NET.Build.Tasks.csproj | Removed FSharp.NET.Sdk from the Stage0SdkFile items used for performance test layout |
| src/Layout/redist/targets/BundledSdks.targets | Removed FSharp.NET.Sdk entry from the BundledSdk list, eliminating its inclusion in the SDK bundle |
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FSharp.props
Outdated
Show resolved
Hide resolved
baronfel
approved these changes
Nov 11, 2025
MichaelSimons
commented
Nov 11, 2025
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FSharp.props
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
MichaelSimons
force-pushed
the
FSharp.NET.Sdk
branch
from
18688f4 to
70fcfc0
Compare
MiYanni
approved these changes
Nov 11, 2025
T-Gro
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #48818