Skip to content

Adds RequestVariablesToRequestFacadeRector rule #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2024
Merged

Adds RequestVariablesToRequestFacadeRector rule #265

merged 2 commits into from
Oct 26, 2024

Conversation

@peterfox
Copy link
Collaborator

@peterfox peterfox commented Oct 26, 2024 •
edited
Loading

Changes

  • Adds RequestVariablesToRequestFacadeRector rule
  • Adds tests
  • Updates Docs

Why

Provides a nice transition from vanilla PHP to Laravel code.

-$_GET['value'];
-$_POST['value'];
-$_GET['value']['sub_value'];
+\Illuminate\Support\Facades\Request::input('value');
+\Illuminate\Support\Facades\Request::input('value');
+\Illuminate\Support\Facades\Request::input('value.sub_value');

@peterfox peterfox added the enhancement New feature or request label Oct 26, 2024
@peterfox peterfox self-assigned this Oct 26, 2024
@GeniJaho GeniJaho merged commit 7fbb1de into main Oct 26, 2024
5 checks passed
@GeniJaho GeniJaho deleted the feature/global-to-request-facade branch October 26, 2024 13:46
@TomasVotruba
Copy link
Collaborator

TomasVotruba commented Dec 20, 2024

Epic, I'll definitely use this one 🤗 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@peterfox peterfox

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterfox @TomasVotruba @GeniJaho