HelperFuncCallToFacadeClassRector, allow with argument
#318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfox
reviewed
Mar 22, 2025
Comment on lines
66
to
70
| if (count($node->args) !== 1) { | ||
| return null; | ||
| return $this->nodeFactory->createStaticCall('Illuminate\Support\Facades\App', 'make', $node->args); | ||
| } | ||
|
|
||
| return $this->nodeFactory->createStaticCall('Illuminate\Support\Facades\App', 'get', $node->args); |
Collaborator
There was a problem hiding this comment.
We have to be careful changing the logic because at current your code would change app() use to App::make().
That said this rule is a bit broken and should be using make over get because they have slightly different behaviours in that get will throw and exception if the abstract does not exist and make just returns null. app(<service>) uses make.
I think the following is right:
if (count($node->args) > 0) {
return $this->nodeFactory->createStaticCall('Illuminate\Support\Facades\App', 'make', $node->args);
}
return null;There needs to be tests that cover skipping app() with no arguments if they don't exist already.
Contributor
Author
There was a problem hiding this comment.
@peterfox thank you for pointing that out, i totally missed the no-argument scenario.
Contributor
Author
|
@peterfox, i have updated the code and added the test case for no-argument. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will change
resolvehelper toApp::getfacade.And allow change to
App::makefacade, in case of more than 1 argument.