-
Notifications
You must be signed in to change notification settings - Fork 86
Fix dependency issue #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix dependency issue #308
Conversation
…bsocket subscriptions by using a simple thread an wrapping the problematic async call.
dddffa0 to
99547ee
Compare
|
At least locally i get a FLAKY error on the test test_order(). I would appreciate some help, or collaborating effort to solve this, as I am not familiar with those parts of the client. here is the output of the failing test. test_order(): test_order_id = subaccount_id { test_address = 'dydx14zzueazeh0hj67cghhf9jypslcf9sh2n5k6art', private_key = <ecdsa.keys.SigningKey object at 0x109dacd50>
tests/test_mutating_node_client.py:104: tests/test_mutating_node_client.py:99: in test_order response = tx_response {
E assert False tests/test_mutating_node_client.py:30: AssertionError |
|
Hey thanks for the PR, seems the proto lib already got updated, is your question on the test order still open? |
Hey there, thanks for coming back at this. I haven't been active in this area since, so from my side you can close it - although it seems there are still unsorted dependency issues around proto, as I can see in another issue opened recently (#394). If this will be sorted to the newest version of proto, I expect my issue will be automatically resolved;) |
This PR updates the v4-proto dependency to 7.0.5 which hopefully fixes the dependency issue due to the version 5.2.1 being yanked.