Skip to content

feat: Add getHeightWithHeaders to Utility Module #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaredvu merged 2 commits into from
Dec 12, 2025
Merged

feat: Add getHeightWithHeaders to Utility Module #464

jaredvu merged 2 commits into from
Dec 12, 2025

Conversation

@jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Dec 12, 2025 •
edited
Loading

  • get Fn swallows response headers and only returns data
  • Added new get Fn that will return headers as well. Headers will be used for geo restriction

@jaredvu jaredvu requested a review from a team as a code owner December 12, 2025 22:04
@jaredvu jaredvu changed the title v3.2.1: Add getHeightWithHeaders to Utility Module feat: Add getHeightWithHeaders to Utility Module Dec 12, 2025
qardpeet
qardpeet reviewed Dec 12, 2025
View reviewed changes
v4-client-js/package.json
{
"name": "@dydxprotocol/v4-client-js",
"version": "1.3.17",
"version": "3.2.1",
Copy link

@qardpeet qardpeet Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with the big jump here?

Copy link
Contributor Author

@jaredvu jaredvu Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the deploy script actually updates this automatically so nobody was updating it here. I just caught it up to the actual client version

@jaredvu jaredvu requested a review from qardpeet December 12, 2025 23:13
@jaredvu jaredvu merged commit 074c16e into main Dec 12, 2025
6 checks passed
@jaredvu jaredvu deleted the jv/height-with-headers branch December 12, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qardpeet qardpeet qardpeet approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaredvu @qardpeet