get_scores() support for factor scores from Factor_analysis()
#1121
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the get_scores() function to support factor scores from factor_analysis(), expanding its utility. The documentation has been updated to reflect this change, and a minor code modification was made for consistency.
Highlights
- Functionality Enhancement: The
get_scores()function now supports factor scores derived fromfactor_analysis()in addition to principal component analysis. - Documentation Update: The documentation for
get_scores()has been updated to reflect the new functionality, including changes to the title, description, arguments, details, and seealso sections. - Code Modification: The
closest_component()function's argument name has been changed frompca_resultstoxfor consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request modifies the get_scores() function to support factor scores from Factor_analysis() in addition to principal component analysis. This involves updating documentation and function parameters to reflect the broader applicability of the function to both PCA and FA results.
|
|
||
| #' @rdname principal_components | ||
| #' @export | ||
| closest_component <- function(pca_results) { | ||
| if ("closest_component" %in% names(attributes(pca_results))) { | ||
| attributes(pca_results)$closest_component | ||
| closest_component <- function(x) { | ||
| if ("closest_component" %in% names(attributes(x))) { |
There was a problem hiding this comment.
The argument name pca_results is not consistent with the function's purpose after this change. It now accepts more general input than just PCA results. Consider renaming it to x to match the argument name used in the function definition and to reflect the broader applicability to both PCA and FA results.
closest_component <- function(x) {
if ("closest_component" %in% names(attributes(x))) {
Fixes #1120