Bootstrap for intercept-only models #1129
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical bug in the bootstrap_model() function that previously prevented it from working correctly with intercept-only statistical models. The core change involves a subtle but important adjustment to how data is subsetted during the bootstrapping process, ensuring that the data structure is preserved, which was the root cause of the failure. A new test case has been added to confirm the fix.
Highlights
- Bug Fix: Addressed an issue where the
bootstrap_model()function would fail when applied to intercept-only models. - Data Subsetting Logic: Modified the data subsetting mechanism within
bootstrap_model.defaultandbootstrap_model.nestedLogitto explicitly prevent dimension dropping when selecting samples, ensuring the data structure remains consistent for model updates. - New Test Case: Introduced a dedicated test case to validate the correct behavior of
bootstrap_model()with intercept-only linear models, ensuring the fix is robust. - Version Update: The package version has been incremented to
0.26.0.13to reflect this bug fix.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where bootstrap_model() failed for intercept-only models by ensuring that the resampled data remains a data frame. A regression test is added, and I've provided some suggestions to improve its clarity and correctness.
Fixes #1128