labels for pscl #1131
labels for pscl #1131
Conversation
Fixes #1126
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a specific bug related to the display of parameter labels for zeroinfl and hurdle models originating from the pscl R package. The changes ensure that when users request pretty names based on labels, the output correctly reflects these labels, improving the clarity and usability of model summaries for these specific model types.
Highlights
- Bug Fix:
psclModel Labels: Resolved an issue where printing labels as pretty names (pretty_names = "labels") for models from thepsclpackage (specificallyzeroinflandhurdlemodels) did not work as expected. The output now correctly displays the assigned labels. - Code Logic Enhancement: Modified the
format_parameters.parameters_modelfunction inR/format_parameters.Rto correctly handlepsclmodels. Forzeroinflandhurdlemodels, thepretty_labelsare now prefixed withcount_andzero_to ensure proper matching with parameters, allowing labels to be applied correctly. - New Test Coverage: Added a new test case in
tests/testthat/test-pretty_names.Rand a corresponding snapshot intests/testthat/_snaps/pretty_names.mdto validate the fix forpsclmodel label printing, ensuring the functionality remains stable.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes an issue with printing labels as pretty names for models from the pscl package. The changes correctly handle the count_ and zero_ prefixes for parameters in zeroinfl and hurdle models. A new test case with a snapshot validates the fix.
There was a problem hiding this comment.
Pull Request Overview
Adds support for using column labels as “pretty names” when formatting zero-inflated or hurdle models from the pscl package, along with tests and documentation updates.
- Prefixes parameter names with
count_/zero_informat_parameters()to align with pscl internals - Adds a new test case and snapshot for
pretty_names = "labels"with pscl models - Updates NEWS and bumps package version
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-pretty_names.R | New test for pretty_names = "labels" on pscl models |
| tests/testthat/_snaps/pretty_names.md | Updated snapshot to include the pscl “labels” output |
| R/format_parameters.R | Handles zeroinfl/hurdle model prefixes for labels |
| NEWS.md | Documents the fix for pscl label printing |
| DESCRIPTION | Bumps version to 0.26.0.15 |
Comments suppressed due to low confidence (4)
tests/testthat/test-pretty_names.R:73
- [nitpick] The test description references
pretty_labelsbut the argument ispretty_names. Consider updating the description topretty_names, psclfor clarity.
test_that("pretty_labels, pscl", {
NEWS.md:39
- [nitpick] Use consistent code formatting in NEWS (e.g. backticks) for package names: replace
*pscl*with`pscl`.
*pscl*, i.e. `print(model_parameters(model), pretty_names = "labels")` now
R/format_parameters.R:431
- [nitpick] Indent this new block to match the project's established style (e.g., two spaces instead of four) for consistency.
if (inherits(model, "zeroinfl") || inherits(model, "hurdle")) {
Fixes #1126