-
-
Notifications
You must be signed in to change notification settings - Fork 40
Purely internal need #1143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purely internal need #1143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on internal code cleanup and standardization related to HTML table rendering. My aim was to streamline the process of determining which HTML backend (like 'gt' or 'tinytable') should be used for displaying various model outputs, making the codebase more maintainable and consistent.
Highlights
- Refactoring HTML Backend Selection: I've refactored the logic for selecting the HTML rendering backend (e.g., 'gt' or 'tinytable') by introducing a new internal helper function,
.check_format_backend. This centralizes the decision-making process and reduces redundant code across various display and print functions. - Parameter Renaming: The
engineparameter, previously used to specify the HTML rendering engine, has been consistently renamed tobackendacross relevant functions. This improves clarity and aligns with the new centralized backend selection logic. - Simplified Function Signatures: Default
engineparameters and explicitinsight::validate_argumentcalls have been removed from manyprint_htmland internal helper functions. The new.check_format_backendfunction now handles the validation and selection of the appropriate HTML backend implicitly via the...arguments.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an internal refactoring to standardize the handling of HTML output backends. The main changes involve replacing the engine parameter with backend and introducing a new helper function, .check_format_backend, to centralize logic.
While the changes are mostly consistent, I've identified a few critical issues that could lead to runtime errors, as well as some opportunities for code simplification and improved maintainability. My main concerns are around the visibility of the new helper function and potential duplicate argument passing.
Please see my detailed comments below.
No description provided.