Update / check snapshot #1150
Update / check snapshot #1150
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the package version and refreshes existing snapshot tests. These changes are likely in response to a fix for issue #1149, which might have altered the output formatting of certain functions, necessitating the snapshot updates to maintain consistency.
Highlights
- Package Version Increment: The
parameterspackage version has been updated from0.28.0to0.28.0.1. - Snapshot Test Refresh: The snapshot file
tests/testthat/_snaps/compare_parameters.mdwas updated to reflect changes in the output formatting ofcompare_parametersfunction, specifically adjusting column widths and adding indentation to parameter names in the printed tables.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the package version and test snapshots. The changes to the snapshots appear to be due to updates in dependencies, which have resulted in a new table format. While the new format generally improves readability by indenting grouped parameters, I've identified a minor formatting issue in one of the updated snapshots where a summary row is incorrectly indented. My specific comment addresses this.
| +------------------+-----------------------+--------+-----------------------+--------+ | ||
| | | | | | | | ||
| +------------------+-----------------------+--------+-----------------------+--------+ | ||
| | Observations | 180 | | 180 | | |
There was a problem hiding this comment.
The Observations row is now indented. This appears to be a minor formatting issue. Since this row represents a summary statistic for the model and is not part of any parameter group (like Controls), it probably should not be indented.
Fixes #1149