-
-
Notifications
You must be signed in to change notification settings - Fork 40
Test on marginaleffects-dev #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily updates the DESCRIPTION file. The changes involve incrementing the package version and adding a new remote dependency. This modification likely facilitates testing or integration with the development version of the marginaleffects package, preparing the environment for related development or CI/CD processes.
Highlights
- Version Update: The package version has been bumped from "0.28.0.4" to "0.28.0.5".
- New Remote Dependency: The DESCRIPTION file now includes "vincentarelbundock/marginaleffects" in its Remotes field, indicating a new development dependency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the package version and adds the development version of the marginaleffects package to the Remotes field in the DESCRIPTION file. This change allows for testing against an unreleased version of the marginaleffects package from its GitHub repository. The changes are correct and appropriate for the stated purpose. I have reviewed the modifications and found no issues.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
- Coverage 63.40% 63.39% -0.01%
==========================================
Files 192 192
Lines 14493 14495 +2
==========================================
Hits 9189 9189
- Misses 5304 5306 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gemini-code-assist review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the package to test against the development version of marginaleffects (#1154), incorporating compatibility changes for the updated API. The changes address modifications in marginaleffects that affect how predictions are handled and how model components are accessed.
Key changes:
- Updated marginaleffects integration to use new API methods
- Removed deprecated
marginalmeansclass support - Modified test expectations for updated formatting output
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/testthat/test-marginaleffects.R |
Updated test to use new allow_new_levels parameter and adjusted expected column names |
tests/testthat/_snaps/wrs2.md |
Updated snapshots to reflect minor formatting changes in numeric output |
tests/testthat/_snaps/printing-stan.md |
Updated snapshots removing .00 decimal formatting from ESS values |
tests/testthat/_snaps/brms.md |
Updated snapshots removing .00 decimal formatting from ESS values |
R/methods_marginaleffects.R |
Replaced deprecated API calls with new marginaleffects::components() method |
NAMESPACE |
Removed export for deprecated marginalmeans class |
DESCRIPTION |
Updated version and added marginaleffects remote dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the package for compatibility with the development version of marginaleffects. Key changes include using the marginaleffects::components() accessor function instead of direct attribute access, which enhances maintainability. The PR also removes obsolete code for marginalmeans and updates tests and snapshots accordingly. The changes are solid and improve the codebase.
Include changes from #1154