Resolvable secrets #3831
Draft
Resolvable secrets #3831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnonnenmacher
force-pushed
the
resolvable-secrets
branch
4 times, most recently
from
a9ba072 to
b9f4056
Compare
mnonnenmacher
force-pushed
the
resolvable-secrets
branch
from
b9f4056 to
36e4741
Compare
Add a class that describes a secret and the source that it can be resolved from. It will taken into use for ORT plugin configurations in the following commits. Signed-off-by: Martin Nonnenmacher <[email protected]>
Add a variant of `PluginConfig` that uses `ResolvableSecret` to record the source from which a secret must be resolved. It will be taken into use for ORT plugin configurations in the following commits. Signed-off-by: Martin Nonnenmacher <[email protected]>
Use the new `ResolvablePluginConfig` class instead of `PluginConfig` in job configurations to prepare for supporting the resolution of plugin secrets also from user configured secrets. At this point, all plugin secrets are still resolved from admin secrets. Signed-off-by: Martin Nonnenmacher <[email protected]>
The service will be used to resolve secrets from the hierarchy. Signed-off-by: Martin Nonnenmacher <[email protected]>
The class mainly tests the worker context itself, not the factory. Signed-off-by: Martin Nonnenmacher <[email protected]>
Signed-off-by: Martin Nonnenmacher <[email protected]>
The function will be used to avoid the need for accessing the secret storage directly. Signed-off-by: Martin Nonnenmacher <[email protected]>
Create the `ContextFactoryTestHelper` in a central place instead of in every single test. Signed-off-by: Martin Nonnenmacher <[email protected]>
Make the constructor arguments of `ContextFactoryTesteHelper` class properties because they were always initialized with the default values anyway. Signed-off-by: Martin Nonnenmacher <[email protected]>
Use the `SecretService` to resolve secret values instead of creating a separate instance of `SecretStorage` in `WorkerContextImpl`. Signed-off-by: Martin Nonnenmacher <[email protected]>
mnonnenmacher
force-pushed
the
resolvable-secrets
branch
from
36e4741 to
381268c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP