-
Notifications
You must be signed in to change notification settings - Fork 5
Use the parent's maven-source-plugin version. #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use the parent's maven-source-plugin version. #32
Conversation
It's probably 3.2.1, not 3.3.x. Refer to the comment below: https://github.com/eclipse-ee4j/glassfish-grizzly/blob/2f34e152864e2bdc76c46ed07f373f5923dc8a13/boms/bom/pom.xml#L188-L195
|
|
Yes, I was hoping that fix would fix it, but I'm still getting the same error. It seems to be related to the parent project pom above, but I haven't found a definitive solution yet. |
|
It's perhaps due to very bad maven goals:
Calling |
|
Also - using |
|
Also |
|
I think I'll need to replace the old script. Is there a job in the Glassfish project that I can refer to? Maybe referencing https://ci.eclipse.org/glassfish/view/Release/job/1_concurro-build-and-stage/ |
|
Is it possible that we can't currently release Glassfish-related projects? Is a deploy-snapshot like https://ci.eclipse.org/glassfish/view/Release/job/concurro-deploy-snapshot/ I was wondering if there were any jobs I could reference at https://ci.eclipse.org/glassfish/view/Release/ |
No, it isn't. All projects can be released to Central, but without staging to separate repository. For example - https://www.eclipse.org/lists/glassfish-dev/msg01699.html - announced that GF 7.1.0-M1 was published successfully.
Since https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/5854 this process has changed.
From the name - it's for deployment of SNAPSHOTs only I guess. Not for full release. |
|
Thank you so much for your kind explanation. I will read it carefully and refer to it. |
If you would wait until the next week, I can upgrade Grizzly just like other, so the deployment to Central will be easier than ever was :-) |
|
So this PR could be closed, right? There is no need to go backward. And the actual message is pointing out to the fault in project configuration of plugin or to the inappropriate maven call. |
|
To clarify
there is no easy way to release from staging to Central Portal now As the nomenclature
|
|
Yes, I would close it. However I have noticed something in the Eclipse Parent today too. It sets the plugin management - it is better to override it in own pluginManagement, not just in plugins. Overriding version number is simple, overriding+disabling executions means explicitly using their id and mapping them to phase "none" or "disabled" etc. Then there is the oss-release profile, which does many things ... while ie. Soteria has its own profile, so it doesn't trigger this. |
Yes, the pressure is to keep good old maven standards: continuous integration, repeatable builds, so testing with snapshot should have same results with the release made immediately after that, release safely possible in few hours. All that was an issue in the past:
|
It looks great. I'll be waiting for you to upgrade Grizzly. Please let me know when the work is done. |
|
@dmatej Eclipse Parent v1.0.9 doesn't appear to use Central. |
It's probably 3.2.1, not 3.3.x.
Refer to the comment below:
https://github.com/eclipse-ee4j/glassfish-grizzly/blob/2f34e152864e2bdc76c46ed07f373f5923dc8a13/boms/bom/pom.xml#L188-L195