Mark ImageDataAtSizeProvider as referenceable #2922
Merged
+216
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arunjose696
force-pushed
the
arunjose696/ImageDataAtSizeProviderReferencable
branch
from
3ff2114 to
ad26c15
Compare
akurtakov
reviewed
Dec 30, 2025
binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
akurtakov
requested changes
Dec 30, 2025
...les/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/ImageDataAtSizeProvider.java
Outdated
Show resolved
Hide resolved
arunjose696
force-pushed
the
arunjose696/ImageDataAtSizeProviderReferencable
branch
3 times, most recently
from
062c96b to
50b1d80
Compare
arunjose696
force-pushed
the
arunjose696/ImageDataAtSizeProviderReferencable
branch
3 times, most recently
from
4a5b73f to
845a9b3
Compare
akoch-yatta
force-pushed
the
arunjose696/ImageDataAtSizeProviderReferencable
branch
2 times, most recently
from
92b210d to
86467c2
Compare
Contributor
|
@akurtakov Can you have a second look here? I took that PR over and added api_filters that look okay to me. |
akurtakov
approved these changes
Jan 2, 2026
Member
akurtakov
left a comment
akurtakov
left a comment
There was a problem hiding this comment.
Ideally, it should be a commented api filter with link to this issue. But it's not a blocker for me.
akoch-yatta
force-pushed
the
arunjose696/ImageDataAtSizeProviderReferencable
branch
from
86467c2 to
5169c58
Compare
Contributor
|
Thank you @akurtakov There is no issue for that, but I added a comment to each filter. I assume your approval as still valid and will merge it when the build is green |
akoch-yatta
deleted the
arunjose696/ImageDataAtSizeProviderReferencable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.