fix: remove dev_dependency flag from google_benchmark

[AlexanderLanin]

google_benchmark cannot be a dev_dependency. Rules for dev_dependency still not understood.... but we need this fix in reference_integration, otherwise it does not work at all.

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: a9ee20de-2d4b-4099-991a-e4b47adb942b
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_rust', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'platforms', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)
Analyzing: target //:license-check (5 packages loaded, 0 targets configured)

Analyzing: target //:license-check (84 packages loaded, 9 targets configured)

Analyzing: target //:license-check (109 packages loaded, 201 targets configured)

Analyzing: target //:license-check (152 packages loaded, 2648 targets configured)

Analyzing: target //:license-check (153 packages loaded, 6907 targets configured)

INFO: Analyzed target //:license-check (156 packages loaded, 8923 targets configured).
[10 / 14] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache ... (2 actions, 0 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 65 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.605s, Critical Path: 0.47s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[Copilot]

Pull Request Overview

This PR removes the dev_dependency = True flag from the google_benchmark dependency, converting it from a development-only dependency to a regular dependency in the build system.

Key Changes

• Changed google_benchmark from a dev dependency to a production dependency in MODULE.bazel

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The google_benchmark dependency should include dev_dependency = True since it's only used for benchmarking tests (see src/cpp/tests/bm_kvs.cpp). This follows the same pattern as other test-only dependencies in this file like googletest, rules_python, rust, and score_toolchains_gcc. Without this flag, the benchmark library will be included in production builds unnecessarily, potentially increasing build times and binary sizes.

Suggested change

	bazel_dep(name = "google_benchmark", version = "1.9.4")
	bazel_dep(name = "google_benchmark", version = "1.9.4", dev_dependency = True)

[github-actions]

The created documentation from the pull request is available at: docu-html