Test Cases for default values in case of CPP added #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saumya-R
changed the title
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
Saumya-R
force-pushed
the
saumya_cpp_default_values_test
branch
2 times, most recently
from
f484ec1 to
3e5a5c6
Compare
|
The created documentation from the pull request is available at: docu-html |
Saumya-R
force-pushed
the
saumya_cpp_default_values_test
branch
5 times, most recently
from
0dfea6f to
76e5d88
Compare
adding hash file generations
Saumya-R
force-pushed
the
saumya_cpp_default_values_test
branch
from
6e98d14 to
f011478
Compare
Contributor
|
Run locally |
PiotrKorkus
reviewed
Nov 20, 2025
Comment on lines
+132
to
+139
| let value_is_default = match kvs.is_value_default(key) { | ||
| Ok(v) => format!("Ok({})", v), | ||
| Err(e) => to_str(&Err::<bool, rust_kvs::error_code::ErrorCode>(e)), | ||
| }; | ||
| let current_value = match kvs.get_value_as::<f64>(key) { | ||
| Ok(v) => format!("Ok(F64({:.1}))", v), | ||
| Err(e) => to_str(&Err::<f64, rust_kvs::error_code::ErrorCode>(e)), | ||
| }; |
Contributor
There was a problem hiding this comment.
Why do we need to modify rust code? Cant just C++ match outputs we already have?
Contributor
Author
There was a problem hiding this comment.
- Justification for changes to Rust code:
- The issue is that the Rust tracer outputs native types (e.g., numbers, booleans) in JSON, while the C++ TRACE macro currently stringifies all data, making everything a string in the output.
- For pytest fixtures to interpret both Rust and C++ outputs identically, we have two options:
1. Change the C++ TRACE macro (or logging method) to output native types.
2. Change the Rust test code to stringify its data.
Refactor C++ main exception handling to use unique exit codes for errors. Extract hash file creation into a separate function for clarity. Remove redundant temp_dir logic from Python fixtures and rely on pytest setup. Remove leftover get_binary usage in pytest configuration. Suppress unnecessary defaults file warnings in conftest.py. Replace explicit srcs list with glob in Bazel BUILD for maintainability. Ensure output parity between Rust and C++ scenario runners. The Rust tracer outputs native types in JSON, while the C++ TRACE macro stringifies all data. To enable pytest fixtures to interpret both outputs identically, updated the Rust test code.
Saumya-R
force-pushed
the
saumya_cpp_default_values_test
branch
from
97ec258 to
5548a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds C++ test cases for default values scenarios to achieve parity with existing Rust tests. The implementation includes a temporary workaround to create hash files for C++ KVS, which requires them for validation (unlike Rust). The changes enable parameterized testing across both Rust and C++ versions.
Key changes:
Added C++ test scenarios for default values testing (default_values, remove_key, reset operations, checksum)
Implemented temporary hash file generation in Python test fixtures to support C++ requirements
Modified Rust test scenarios to use string-based result logging for cross-language compatibility
The CPP KVS needs a hash file which is not needed by RUST , leading to failure of test cases.
Created the issue at : #170