Update minimal CMake version to 3.13 #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anything under 3.5 was breaking build scripts (for FileX and for other components that use FileX as a dependency e.g. NetXDuo)
Contributor
Author
|
Failed check seems to be from the CI/CD pipeline. I was able to successfully run the |
fdesbiens
reviewed
May 15, 2025
Contributor
fdesbiens
left a comment
fdesbiens
left a comment
There was a problem hiding this comment.
Good catch! We did not release FileX since v6.4.1 yet so it did not get the CMake version updates the others did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything under 3.5 was breaking build scripts.
Discovered this after trying to build NetXDuo. Ran the
install.shscript in thenetxduo/scripts/folder, then realized it had updated CMake to 4.0+ and could no longer run thebuild_nxd.shscript because the FileX dependency build failed.