chore: add missing assets in github release #1619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-luna
commented
Jun 16, 2025
| }, | ||
| "packages/rum": { | ||
| "name": "@elastic/apm-rum", | ||
| "version": "5.16.3", |
Member
Author
There was a problem hiding this comment.
note for reviewer: the release process seems to forget to bump versions here so we get these changes when running npm i at root folder.
david-luna
commented
Jun 16, 2025
| /** | ||
| * Exclude the files that are not required for releasing | ||
| * | ||
| * TODO: Remove this filtering logic once we revisit bundling steps |
Member
Author
There was a problem hiding this comment.
note for reviewer: it seems we forgot this TODO and that's why we do not have *.map files
Member
There was a problem hiding this comment.
We dont have any files other than .js and .map? Just checking.
Member
Author
There was a problem hiding this comment.
no, just .js and .map files
vigneshshanmugam
approved these changes
Jun 17, 2025
| /** | ||
| * Exclude the files that are not required for releasing | ||
| * | ||
| * TODO: Remove this filtering logic once we revisit bundling steps |
Member
There was a problem hiding this comment.
We dont have any files other than .js and .map? Just checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github release for
rum-coredoes not add the*.mapfiles.Fixes: #1608