Skip to content

chore: add provenance and trusted publishers in release workflow #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

chore: add provenance and trusted publishers in release workflow #1651

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc50cf5
chore: update workflos and add provenance flag in packages
david-luna Oct 28, 2025
7c1a80f
chore: remove secret tokens in release process
david-luna Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pre-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
node-version-file: '.nvmrc'

- name: Install dependencies
run: npm ci
run: npm ci --ignore-scripts

# This prevent lerna command from throwing this error:
# "Working tree has uncommitted changes, please commit or remove the following changes before continuing"
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ on:

permissions:
contents: read
id-token: write

env:
ELASTIC_CDN_BUCKET_NAME: ${{ inputs.dry-run == false && 'apm-rum-357700bc' || 'oblt-apm-rum-test' }}
Expand All @@ -22,9 +23,6 @@ env:
jobs:
release:
runs-on: ubuntu-latest
permissions:
contents: read
id-token: write
Comment on lines 25 to 27
Copy link
Member

@v1v v1v Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this as is, we normally follow this pattern:

  • default top-level permissions as is
  • job permissions with finer-granularity

Copy link
Member Author

@david-luna david-luna Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit 7c1a80f

services:
verdaccio:
image: verdaccio/verdaccio:5
Expand Down Expand Up @@ -57,7 +55,7 @@ jobs:
node-version-file: '.nvmrc'

- name: Install dependencies
run: npm ci
run: npm ci --ignore-scripts

# This prevent lerna command from throwing this error:
# "Working tree has uncommitted changes, please commit or remove the following changes before continuing"
Expand Down
3 changes: 2 additions & 1 deletion packages/rum-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"license": "MIT",
"publishConfig": {
"access": "public",
"directory": "dist"
"directory": "dist",
"provenance": true
},
"repository": {
"type": "git",
Expand Down
3 changes: 2 additions & 1 deletion packages/rum-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"source": "src/index.js",
"sideEffects": false,
"publishConfig": {
"access": "public"
"access": "public",
"provenance": true
},
"repository": {
"type": "git",
Expand Down
3 changes: 2 additions & 1 deletion packages/rum-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"node": ">=8.0.0"
},
"publishConfig": {
"access": "public"
"access": "public",
"provenance": true
},
"repository": {
"type": "git",
Expand Down
3 changes: 2 additions & 1 deletion packages/rum-vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@
"script": "node ../../dev-utils/run-script.js"
},
"publishConfig": {
"access": "public"
"access": "public",
"provenance": true
},
"repository": {
"type": "git",
Expand Down
3 changes: 2 additions & 1 deletion packages/rum/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
"directory": "packages/rum"
},
"publishConfig": {
"access": "public"
"access": "public",
"provenance": true
},
"scripts": {
"prepublishOnly": "npm run build",
Expand Down
Loading