-
Notifications
You must be signed in to change notification settings - Fork 190
[Do not merge] Convert tabs that can be applies-switch #4429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
florent-leborgne
wants to merge
10
commits into
elastic:main
Choose a base branch
from
florent-leborgne:convert-tabs-into-applies-switch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
42d194f
convert some tabs into applies-switch
florent-leborgne cbde482
typo
florent-leborgne dd13a1a
Merge branch 'main' into convert-tabs-into-applies-switch
florent-leborgne c9689e7
fixes
florent-leborgne d435b94
simplify
florent-leborgne 95af9b4
fix
florent-leborgne 3837b66
the right fixes
florent-leborgne ca36768
Merge branch 'main' into convert-tabs-into-applies-switch
florent-leborgne 80a0851
another missed one
florent-leborgne 187086e
Merge branch 'convert-tabs-into-applies-switch' of github.com:florent…
florent-leborgne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,11 +51,9 @@ The maximum number of spaces that you can have differs by deployment type: | |
|
|
||
| To create a space: | ||
|
|
||
| :::::{tab-set} | ||
| :group: stack-serverless | ||
| :::::{applies-switch} | ||
|
|
||
| ::::{tab-item} {{serverless-short}} | ||
| :sync: serverless | ||
| ::::{applies-item} serverless: | ||
|
|
||
| 1. Click **Create space** or select the space you want to edit. | ||
| 2. Provide: | ||
|
|
@@ -67,8 +65,7 @@ To create a space: | |
| 4. Save the space. | ||
| :::: | ||
|
|
||
| ::::{tab-item} {{stack}} | ||
| :sync: stack | ||
| ::::{applies-item} stack: | ||
|
|
||
| 1. Select **Create space** and provide a name, description, and URL identifier. | ||
| The URL identifier is a short text string that becomes part of the {{kib}} URL when you are inside that space. {{kib}} suggests a URL identifier based on the name of your space, but you can customize the identifier to your liking. You cannot change the space identifier once you create the space. | ||
|
|
@@ -95,8 +92,8 @@ You can edit all of the space settings you just defined at any time, except for | |
|
|
||
| Elastic also allows you to manage spaces using APIs: | ||
|
|
||
| * **Serverless projects:** [Spaces API](https://www.elastic.co/docs/api/doc/serverless/operation/operation-get-spaces-space) | ||
| * **{{stack}} deployments:** [Spaces API](https://www.elastic.co/docs/api/doc/kibana/operation/operation-post-spaces-copy-saved-objects) | ||
| * {applies_to}`serverless:` [Spaces API](https://www.elastic.co/docs/api/doc/serverless/operation/operation-get-spaces-space) | ||
| * {applies_to}`stack:` [Spaces API](https://www.elastic.co/docs/api/doc/kibana/operation/operation-post-spaces-copy-saved-objects) | ||
|
Comment on lines
+95
to
+96
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this is a good case for applies tags because it's harder to read |
||
|
|
||
|
|
||
| ## Define access to a space [spaces-control-user-access] | ||
|
|
@@ -105,8 +102,8 @@ Users can access spaces based on the roles that they have. | |
|
|
||
| * Certain reserved roles can view and access all spaces by default. You can’t prevent those roles from accessing a space. Instead, you can grant different roles to your users. | ||
| * When creating or editing a role, you can define which existing spaces that role can access, and with which permissions. Role management differs between {{stack}} deployments and serverless projects. | ||
| - For Serverless projects, check [Custom roles](/deploy-manage/users-roles/cloud-organization/user-roles.md). | ||
| - For {{stack}} deployments, check [Creating or editing a role](/deploy-manage/users-roles/cluster-or-deployment-auth/defining-roles.md). | ||
| - {applies_to}`serverless:` Check [Custom roles](/deploy-manage/users-roles/cloud-organization/user-roles.md). | ||
| - {applies_to}`stack:` Check [Creating or editing a role](/deploy-manage/users-roles/cluster-or-deployment-auth/defining-roles.md). | ||
|
|
||
|
|
||
| If you're managing an {{stack}} deployment, then you can also assign roles and define permissions for a space from the **Permissions** tab of the space settings. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a one-tab applies switch is an anti-pattern. this should be a tag on the section instead.