[Microsoft SQLServer] Add support for list of Dynamic Counter values

[muthu-mps]

• Breaking change

Please see this issue for more details.

This PR adds capability to pass list of dynamic counter values. This way user has more flexibility to add multiple values as input to fetch the desired metrics.

This change introduces a breaking update, which is why we are releasing a new major version. Users will need to manually remove the dynamic counter input from the UI, upgrade the integration, and then re-add the dynamic counters. This is necessary because the input parameter type has changed from text to array.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.
• I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

• [ ]

How to test this PR locally

• Install the 2.12.0 integration version
• Validate the metrics collection.
• Upgrade the integration to 3.0.0. Follow the manual steps mentioned in the document on upgrade.
• Validate the metrics collection.

Related issues

• Closes [Microsoft SQLServer] Add support for List of Dynamic counters #14083

[elastic-vault-github-plugin-prod]

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[ritalwar]

LGTM!

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 5481c52

History

• 💚 Build #26925 succeeded ffc8be5

cc @muthu-mps

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[ishleenk17]

Do we intend to use "i" anywhere, else remove it.

[botelastic]

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

[botelastic]

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

[ishleenk17]

@muthu-mps : I think this is an important enhancement. And I would like to get this through.
I don't see any blocker. Can we take it to closure ?

[muthu-mps]

@muthu-mps : I think this is an important enhancement. And I would like to get this through. I don't see any blocker. Can we take it to closure ?

Yeah I agree there is no blocker, We need to agree upon the breaking upgrade change. cc: @lalit-satapathy

[ishleenk17]

@muthu-mps : I think this is an important enhancement. And I would like to get this through. I don't see any blocker. Can we take it to closure ?

Yeah I agree there is no blocker, We need to agree upon the breaking upgrade change. cc: @lalit-satapathy

Can you point me to the exact point of contention here ?

[muthu-mps]

@muthu-mps : I think this is an important enhancement. And I would like to get this through. I don't see any blocker. Can we take it to closure ?

Yeah I agree there is no blocker, We need to agree upon the breaking upgrade change. cc: @lalit-satapathy

Can you point me to the exact point of contention here ?

Please see this issue for more details.

[botelastic]

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

[botelastic]

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!