Skip to content

feat: Preserve event.original when pipeline errors in integration-experience integrations (part 3) #15805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2025
Merged

feat: Preserve event.original when pipeline errors in integration-experience integrations (part 3) #15805

merged 2 commits into from
Nov 6, 2025

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Oct 29, 2025 •
edited
Loading

Proposed commit message

  • Add append processor to pipeline on_failure handlers to preserve event.original.
  • Add append processor to pipeline to preserve event.original if error.message is set.

Integrations

  • imperva
  • iptables
  • juniper_srx
  • modsecurity
  • netflow
  • panw
  • pfsense
  • proxysg
  • qnap_nas
  • snort
  • sonicwall_firewall

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@taylor-swanson taylor-swanson self-assigned this Oct 29, 2025
@taylor-swanson taylor-swanson added enhancement New feature or request Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Oct 29, 2025
@taylor-swanson taylor-swanson force-pushed the chore/event-original-part3 branch from b739eed to eea70e5 Compare October 29, 2025 17:36
@taylor-swanson taylor-swanson added Integration:panw Palo Alto Next-Gen Firewall Integration:iptables Iptables Integration:snort Snort Integration:sonicwall_firewall SonicWall Firewall Integration:imperva Imperva Integration:juniper_srx Juniper SRX Integration:netflow NetFlow Records Integration:modsecurity ModSecurity Audit (Community supported) Integration:pfsense pfSense (Community supported) Integration:qnap_nas QNAP NAS (Community supported) Integration:proxysg Broadcom ProxySG labels Oct 29, 2025
@taylor-swanson
feat: Preserve event.original when errors occur in pipelines
c1a52e3 
- Added append processor to global on_failure to preserve event original
- Added append processor to default pipelines to preserve event original if error.message is set

Affects the following integrations:

- imperva
- iptables
- juniper_srx
- modsecurity
- netflow
- panw
- pfsense
- proxysg
- qnap_nas
- snort
- sonicwall_firewall
@taylor-swanson taylor-swanson force-pushed the chore/event-original-part3 branch from eea70e5 to c1a52e3 Compare October 29, 2025 17:48
@taylor-swanson taylor-swanson marked this pull request as ready for review November 4, 2025 21:26
@taylor-swanson taylor-swanson requested a review from a team as a code owner November 4, 2025 21:26
@elasticmachine
Copy link

elasticmachine commented Nov 4, 2025

Pinging @elastic/integration-experience (Team:Integration-Experience)

@elasticmachine
Copy link

elasticmachine commented Nov 4, 2025

💚 Build Succeeded

History

cc @taylor-swanson

@taylor-swanson taylor-swanson merged commit 5cc39ca into elastic:main Nov 6, 2025
7 checks passed
@taylor-swanson taylor-swanson deleted the chore/event-original-part3 branch November 6, 2025 17:06
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package imperva - 1.9.0 containing this change is available at https://epr.elastic.co/package/imperva/1.9.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package iptables - 1.22.0 containing this change is available at https://epr.elastic.co/package/iptables/1.22.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package juniper_srx - 1.26.0 containing this change is available at https://epr.elastic.co/package/juniper_srx/1.26.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package modsecurity - 1.22.0 containing this change is available at https://epr.elastic.co/package/modsecurity/1.22.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package netflow - 2.24.0 containing this change is available at https://epr.elastic.co/package/netflow/2.24.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package panw - 5.4.0 containing this change is available at https://epr.elastic.co/package/panw/5.4.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package pfsense - 1.24.0 containing this change is available at https://epr.elastic.co/package/pfsense/1.24.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package proxysg - 0.7.0 containing this change is available at https://epr.elastic.co/package/proxysg/0.7.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package qnap_nas - 1.24.0 containing this change is available at https://epr.elastic.co/package/qnap_nas/1.24.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package snort - 1.20.0 containing this change is available at https://epr.elastic.co/package/snort/1.20.0/

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 6, 2025

Package sonicwall_firewall - 1.20.0 containing this change is available at https://epr.elastic.co/package/sonicwall_firewall/1.20.0/

tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
@taylor-swanson
feat: Preserve event.original when errors occur in pipelines (elastic…
bf6b647 
…#15805)

- Added append processor to global on_failure to preserve event original
- Added append processor to default pipelines to preserve event original if error.message is set

Affects the following integrations:

- imperva
- iptables
- juniper_srx
- modsecurity
- netflow
- panw
- pfsense
- proxysg
- qnap_nas
- snort
- sonicwall_firewall
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haetamoudi haetamoudi haetamoudi approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels

enhancement New feature or request Integration:imperva Imperva Integration:iptables Iptables Integration:juniper_srx Juniper SRX Integration:modsecurity ModSecurity Audit (Community supported) Integration:netflow NetFlow Records Integration:panw Palo Alto Next-Gen Firewall Integration:pfsense pfSense (Community supported) Integration:proxysg Broadcom ProxySG Integration:qnap_nas QNAP NAS (Community supported) Integration:snort Snort Integration:sonicwall_firewall SonicWall Firewall Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@taylor-swanson @elasticmachine @haetamoudi