Skip to content

Conversation

@Linu-Elias
Copy link
Contributor

@Linu-Elias Linu-Elias commented Nov 5, 2025

Proposed commit message

Fix separator regex to consider ",<space>" and "," in X-Forwarded-For

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

--- Test results for package: apache_tomcat - START ---
╭───────────────┬─────────────┬───────────┬────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │
├───────────────┼─────────────┼───────────┼────────────────────────────────────────────┼────────┼──────────────┤
│ apache_tomcat │ access │ pipeline │ (ingest pipeline warnings test-access.log) │ PASS │ 2.944872289s │
│ apache_tomcat │ access │ pipeline │ test-access.log │ PASS │ 253.533747ms │
╰───────────────┴─────────────┴───────────┴────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: apache_tomcat - END ---
Done

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@Linu-Elias Linu-Elias marked this pull request as ready for review November 5, 2025 11:35
@Linu-Elias Linu-Elias requested a review from a team as a code owner November 5, 2025 11:35
@Linu-Elias Linu-Elias requested a review from muthu-mps November 5, 2025 11:40
@Linu-Elias Linu-Elias requested a review from muthu-mps November 5, 2025 11:42
@Linu-Elias Linu-Elias self-assigned this Nov 5, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @Linu-Elias

@andrewkroh andrewkroh added Integration:apache_tomcat Apache Tomcat Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Nov 5, 2025
@Linu-Elias Linu-Elias merged commit 685d79a into elastic:main Nov 6, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package apache_tomcat - 1.12.1 containing this change is available at https://epr.elastic.co/package/apache_tomcat/1.12.1/

tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
…comma delineated IPs (elastic#15873)

* fix

* Update changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:apache_tomcat Apache Tomcat Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants