-
Notifications
You must be signed in to change notification settings - Fork 513
Improve system test coverage - 1 #15923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve system test coverage - 1 #15923
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
asset_vulnerability_summary |
14705.88 | 10526.32 | -4179.56 (-28.42%) | 💔 |
Package cloudflare 👍(1) 💚(0) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
audit |
3759.4 | 3105.59 | -653.81 (-17.39%) | 💔 |
Package sublime_security 👍(1) 💚(1) 💔(1)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
email_message |
901.71 | 764.53 | -137.18 (-15.21%) | 💔 |
Package tanium 👍(1) 💚(2) 💔(3)
Expand to view
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
client_status |
9345.79 | 7092.2 | -2253.59 (-24.11%) | 💔 |
discover |
4484.3 | 3412.97 | -1071.33 (-23.89%) | 💔 |
reporting |
21739.13 | 17543.86 | -4195.27 (-19.3%) | 💔 |
To see the full report comment with /test benchmark fullreport
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message should explain what the improvements are, and given that there are a number of packages affected, this would likely either be sections in the commit message or splitting the PR into distinct PRs for each package (I don't really think this is necessary since the logic of the integrations does not appear to be changed here, but it is an option).
| fields: | ||
| - name: key | ||
| type: keyword | ||
| description: The AWS S3 Object key. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final new line (there are others below).
Yes, i can update the commit message but since there are total 30 integrations so i have planned to raise 3 PRs with 9-10 integrations each. |
|
/test |
|
/test |
💔 Build Failed
Failed CI StepsHistory
|
kcreddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the issue's parent, here we are covering all inputs using multiple service deployers which was not possible earlier.
Adding onto @efd6 point, please update the title and commit message to reflect this.
Also spell check on akamai instead of akmai in commit message.
Proposed commit message
Checklist
changelog.ymlfile.Related issues