Skip to content

fix: Failing test: X-Pack Accessibility Tests.x-pack/test/accessibiliy/apps/dashboard_panel_options·ts - Dashboard panel options a11y tests dashboard panel - clone panel #241259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2025
Merged

fix: Failing test: X-Pack Accessibility Tests.x-pack/test/accessibiliy/apps/dashboard_panel_options·ts - Dashboard panel options a11y tests dashboard panel - clone panel #241259

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5110693
fix: Failing test: X-Pack Accessibility Tests.x-pack/test/accessibili…
alexwizp Oct 30, 2025
efb4e09
Merge branch 'main' into oct039
alexwizp Nov 7, 2025
2826329
Merge branch 'main' into oct039
alexwizp Nov 7, 2025
7e3d17e
Merge branch 'main' into oct039
alexwizp Nov 10, 2025
f72bf89
Merge branch 'main' into oct039
alexwizp Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions x-pack/platform/test/accessibility/apps/group1/dashboard_panel_options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const toasts = getService('toasts');
const inspector = getService('inspector');

// Failing: See https://github.com/elastic/kibana/issues/147667
describe.skip('Dashboard panel options a11y tests', () => {
describe('Dashboard panel options a11y tests', () => {
const title = '[Flights] Flight count';
before(async () => {
await PageObjects.common.navigateToUrl('home', '/tutorial_directory/sampleData', {
Expand Down Expand Up @@ -45,9 +44,11 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {

it('dashboard panel - customize time range', async () => {
await dashboardPanelActions.toggleContextMenuByTitle(title);
await testSubjects.click('embeddablePanelAction-CUSTOM_TIME_RANGE');
await testSubjects.click('embeddablePanelAction-ACTION_CUSTOMIZE_PANEL');
await testSubjects.click('customizePanelShowCustomTimeRange');

await a11y.testAppSnapshot();
await testSubjects.click('cancelPerPanelTimeRangeButton');
await testSubjects.click('cancelCustomizePanelButton');
});

it('dashboard panel- inspect', async () => {
Expand Down Expand Up @@ -81,6 +82,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dashboardPanelActions.clickExpandPanelToggle();
await a11y.testAppSnapshot();
await dashboardPanelActions.clickExpandPanelToggle();
await a11y.testAppSnapshot();
});

it('dashboard panel - copy to dashboard', async () => {
Expand All @@ -107,6 +109,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await a11y.testAppSnapshot();
await testSubjects.click('customEmbeddablePanelHideTitleSwitch');
await testSubjects.click('saveCustomizePanelButton');
await a11y.testAppSnapshot();
});

it('dashboard panel - Create drilldown panel', async () => {
Expand All @@ -130,11 +133,5 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await a11y.testAppSnapshot();
await testSubjects.click('euiFlyoutCloseButton');
});

it('dashboard panel - save to library', async () => {
Copy link
Contributor

@nreese nreese Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this test case removed?

Copy link
Contributor Author

@alexwizp alexwizp Nov 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nreese Most probably this is a bad test — I think the idea was to check a11y for dashboardPanelActions.saveToLibrary modal. In reality, this method performs a save operation and returns us to the UI that we’ve already tested in one of the previous tests. It seems redundant to me.

await dashboardPanelActions.saveToLibrary('', title);
await a11y.testAppSnapshot();
await testSubjects.click('saveCancelButton');
});
});
}