-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Clickable external links to docs from dev console #242026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clickable external links to docs from dev console #242026
Conversation
kowalczyk-krzysztof
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SharedUX code changes LGTM
ElenaStoeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @saikatsarkar056. That's very cool, I didn't know Monaco editors have this option! I left a few comments.
x-pack/platform/test/serverless/functional/test_suites/console/console.ts
Outdated
Show resolved
Hide resolved
src/platform/test/functional/apps/console/_misc_console_behavior.ts
Outdated
Show resolved
Hide resolved
ElenaStoeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback! I left a few follow-up comments. Also, could you run the flaky test runner with x200 just to make sure the new console test is not flaky?
x-pack/platform/test/functional/apps/dev_tools/searchprofiler_editor.ts
Outdated
Show resolved
Hide resolved
| // Following the pattern from ES|QL tests where we hover to show tooltip, then click the option | ||
| const modifierKey = browser.keys[process.platform === 'darwin' ? 'COMMAND' : 'CONTROL']; | ||
|
|
||
| await browser.getActions().keyDown(modifierKey).perform(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we do this given that later we hover over the link and click the link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two ways to open the link:
- Cmd + Click
- Hover over the link to display a tooltip, then click “Follow the link” to open the page in a new tab.
I’ve updated the test so that it now uses only the Cmd + Click method.
|
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9777 |
ElenaStoeva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the last changes! Latest lgtm
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9777[✅] src/platform/test/functional/apps/console/config.ts: 200/200 tests passed. |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
Summary
Several links in the Dev Console are currently shown as plain text and aren’t clickable. Most of these appear in the tutorial journey. This PR makes those links clickable within the Dev Console.
Screen.Recording.2025-11-06.at.11.05.53.AM.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.