[Controls] Fix deselecting (blank) option from options list #242036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
release_note:fix
Feature:Input Control
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
approved these changes
Nov 10, 2025
Member
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm! thanks for the fix and the unit test update! code review
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 10, 2025
…242036) ## Summary Closes elastic#241750 Fixes an error with deselecting a `(blank)` option from an options list. The same error when *selecting* the option was fixed in elastic#239791, but we missed fixing it for deselection. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 783f287)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 10, 2025
…242036) ## Summary Closes elastic#241750 Fixes an error with deselecting a `(blank)` option from an options list. The same error when *selecting* the option was fixed in elastic#239791, but we missed fixing it for deselection. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 783f287)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 10, 2025
…242036) ## Summary Closes elastic#241750 Fixes an error with deselecting a `(blank)` option from an options list. The same error when *selecting* the option was fixed in elastic#239791, but we missed fixing it for deselection. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 783f287)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 10, 2025
…42036) (#242473) # Backport This will backport the following commits from `main` to `9.2`: - [[Controls] Fix deselecting (blank) option from options list (#242036)](#242036) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Zac Xeper","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-10T19:31:00Z","message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Input Control","Team:Presentation","Project:Controls","backport:version","v9.2.0","v9.3.0","v8.19.7","v9.1.7"],"title":"[Controls] Fix deselecting (blank) option from options list","number":242036,"url":"https://github.com/elastic/kibana/pull/242036","mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","8.19","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242036","number":242036,"mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},{"branch":"8.19","label":"v8.19.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Zac Xeper <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 10, 2025
…242036) (#242471) # Backport This will backport the following commits from `main` to `8.19`: - [[Controls] Fix deselecting (blank) option from options list (#242036)](#242036) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Zac Xeper","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-10T19:31:00Z","message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Input Control","Team:Presentation","Project:Controls","backport:version","v9.2.0","v9.3.0","v8.19.7","v9.1.7"],"title":"[Controls] Fix deselecting (blank) option from options list","number":242036,"url":"https://github.com/elastic/kibana/pull/242036","mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","8.19","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242036","number":242036,"mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},{"branch":"8.19","label":"v8.19.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Zac Xeper <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 10, 2025
…42036) (#242472) # Backport This will backport the following commits from `main` to `9.1`: - [[Controls] Fix deselecting (blank) option from options list (#242036)](#242036) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Zac Xeper","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-10T19:31:00Z","message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Input Control","Team:Presentation","Project:Controls","backport:version","v9.2.0","v9.3.0","v8.19.7","v9.1.7"],"title":"[Controls] Fix deselecting (blank) option from options list","number":242036,"url":"https://github.com/elastic/kibana/pull/242036","mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","8.19","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242036","number":242036,"mergeCommit":{"message":"[Controls] Fix deselecting (blank) option from options list (#242036)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/241750\n\nFixes an error with deselecting a `(blank)` option from an options list.\n\nThe same error when *selecting* the option was fixed in\nhttps://github.com//pull/239791, but we missed fixing it\nfor deselection.\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"783f287fb0ec41359eacc335f0258aaebeb377d1"}},{"branch":"8.19","label":"v8.19.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Zac Xeper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #241750
Fixes an error with deselecting a
(blank)option from an options list.The same error when selecting the option was fixed in #239791, but we missed fixing it for deselection.
Checklist