[8.19] Improve rolling appender test logic (#242095) #242260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Closes elastic#232893 The previous improvements were not enough, [latest failure](https://buildkite.com/elastic/kibana-on-merge/builds/81112/steps/canvas?jid=019a4a9c-77de-450f-a4e8-70d4efc34012) shows that we can't guarantee how many times the rolling logic has run: <img width="846" height="272" alt="image" src="https://github.com/user-attachments/assets/9ccaac11-92bb-42cf-8b5a-60fd258c23d9" /> The PR makes the test even more resilient by not assuming that the rolling logid has run exactly twice, and instead it just makes assertions that are valid for the 2 scenarios: * Assert there are multiple log files (rollover has happened). * Assert that the rolled files are not empty * Assert that when concatenating all log files in an ordered fashion, no log entries are lost. (cherry picked from commit 11a9589)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation