Skip to content

Conversation

@jsvd
Copy link
Member

@jsvd jsvd commented Oct 29, 2025

There is no need to apply rubyUtils.gradle to x-pack/build.gralde, which defined the entire set of tasks from the former into the latter. This can lead to confusing situations like running ./gradlew downloadAndInstallJRuby installing JRuby twice (once in project root and another in x-pack/) since gradle will run all tasks matching that name.

Exhaustive test suite passed: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2803/steps/canvas

@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2025

This pull request does not have a backport label. Could you fix it @jsvd? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@jsvd jsvd marked this pull request as ready for review October 29, 2025 18:13
@jsvd jsvd requested a review from yaauie October 29, 2025 18:14
@jsvd jsvd added the backport-9.2 Automated backport to the 9.2 branch label Oct 30, 2025
Copy link
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-9.2 Automated backport to the 9.2 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants