Skip to content

bk(smart exhaustive tests): tune the steps to support GH comments and changesets #18383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 31, 2025
+9 −12
Merged

bk(smart exhaustive tests): tune the steps to support GH comments and changesets #18383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e414c51
chore: test
v1v Oct 30, 2025
5d5ccab
chore: test
v1v Oct 30, 2025
748564e
fix
v1v Oct 30, 2025
4ad6fed
fix
v1v Oct 30, 2025
93ddef7
revert
v1v Oct 30, 2025
f81e169
fix
v1v Oct 30, 2025
8847b3f
finer grained
v1v Oct 30, 2025
8ad4433
fix
v1v Oct 30, 2025
de9741f
revert
v1v Oct 30, 2025
ecdc1d9
Apply suggestion from @v1v
v1v Oct 30, 2025
9df5ac8
fix: issues when running on GH Comments
v1v Oct 30, 2025
2240d82
fix
v1v Oct 30, 2025
01b4d7a
fix
v1v Oct 30, 2025
ffd0899
revert
v1v Oct 30, 2025
0057a8e
fix
v1v Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions .buildkite/smart_exhaustive_tests_pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
steps:
- label: "Trigger logstash-exhaustive-tests-pipeline for PRs with qa/acceptance/ changes"
if: build.pull_request.id != null
if: build.pull_request.id != null && build.env("GITHUB_PR_TRIGGER_COMMENT") != "/run exhaustive tests"
Copy link
Member Author

@v1v v1v Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in case of two events at the same time, a changeset and also a comment

plugins:
- monorepo-diff#v1.0.1:
diff: "git diff --name-only origin/${GITHUB_PR_TARGET_BRANCH}...HEAD"
Expand All @@ -16,19 +16,16 @@ steps:
commit: "${BUILDKITE_COMMIT}"
branch: "${BUILDKITE_BRANCH}"
env:
- BUILDKITE_PULL_REQUEST=${BUILDKITE_PULL_REQUEST}
- BUILDKITE_PULL_REQUEST_BASE_BRANCH=${BUILDKITE_PULL_REQUEST_BASE_BRANCH}
- GITHUB_PR_LABELS=${GITHUB_PR_LABELS}
- ELASTIC_SLACK_NOTIFICATIONS_ENABLE=false
BUILDKITE_PULL_REQUEST: "${BUILDKITE_PULL_REQUEST}"
BUILDKITE_PULL_REQUEST_BASE_BRANCH: "${BUILDKITE_PULL_REQUEST_BASE_BRANCH}"
Comment on lines +19 to +20
Copy link
Member Author

@v1v v1v Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewer: it requires this format, although, I tried to use the same as we have in other places, like beats and didn't work.

Copy link
Member

@donoghuc donoghuc Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A map of env var name with key and its value as the value makes sense

logstash/.buildkite/windows_jdk_matrix_pipeline.yml

Lines 4 to 5 in be64ebf

DEFAULT_MATRIX_OS: "windows-2022"
DEFAULT_MATRIX_JDK: "adoptiumjdk_21"
over a list of string. Good with this.

ELASTIC_SLACK_NOTIFICATIONS_ENABLED: false
Copy link
Member Author

@v1v v1v Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo


- label: "Trigger logstash-exhaustive-tests-pipeline for GitHub comments"
if: build.env("GITHUB_PR_TRIGGER_COMMENT") != ""
if: build.env("GITHUB_PR_TRIGGER_COMMENT") == "/run exhaustive tests"
trigger: "logstash-exhaustive-tests-pipeline"
build:
commit: "${BUILDKITE_COMMIT}"
branch: "${BUILDKITE_BRANCH}"
commit: "HEAD"
branch: "pull/${BUILDKITE_PULL_REQUEST}/merge"
Copy link
Member Author

@v1v v1v Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewer: BK PR bot ehaves awkwardly when supporting GitHub comments, and the previous approach did not work. Please refer to https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/2815


2025-10-30 17:36:23 UTC | fatal: reference is not a tree: ecdc1d984499a63372fcb8992c24864c80ab1e5b
-- | --
  | 2025-10-30 17:36:23 UTC | ⚠️ Warning: Checkout failed! checking out commit "ecdc1d984499a63372fcb8992c24864c80ab1e5b": exit status 128 (Attempt 3/3)
  | 2025-10-30 17:36:23 UTC | 🚨 Error: checking out commit "ecdc1d984499a63372fcb8992c24864c80ab1e5b": exit status 128

Copy link
Member

@donoghuc donoghuc Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is odd. Seems like you found a decent workaround though.

env:
- BUILDKITE_PULL_REQUEST=${BUILDKITE_PULL_REQUEST}
- BUILDKITE_PULL_REQUEST_BASE_BRANCH=${BUILDKITE_PULL_REQUEST_BASE_BRANCH}
- GITHUB_PR_LABELS=${GITHUB_PR_LABELS}
- ELASTIC_SLACK_NOTIFICATIONS_ENABLE=false
BUILDKITE_PULL_REQUEST: "${BUILDKITE_PULL_REQUEST}"
ELASTIC_SLACK_NOTIFICATIONS_ENABLED: false
Copy link
Member Author

@v1v v1v Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Empty file added qa/acceptance/empty.txt
View file
Open in desktop
Empty file.