-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: add nsis support for allowToAddShortcuts(user decides wether to… #9123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… create shortcuts) allows the user to configure wether or not they wish to create shortcuts after finishing installation
🦋 Changeset detectedLatest commit: a461ca2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. [Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/jaywalker15262/electron-builder/new/master?filename=.changeset/odd-bees-grin.md&value=---%0A%22app-builder-lib%22%3A%20patch%0A---%0A%0Afeat%3A%20add%20nsis%20support%20for%20allowToAddShortcuts(user%20decides%20wether%20to%E2%80%A6%0A) |
| * If enabled, the user can opt-in or opt-out at install time. | ||
| * @default false | ||
| */ | ||
| readonly allowToAddShortcut?: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on renaming this to allowToCustomizeShortcuts since it supports customizing desktop and/or start menu. Thinking "Customize" because it allows the user to allow/enable or disable/remove shortcuts from being created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not, good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaywalker15262 I am unable to push changes to this PR to update the property. Can you please attend to this and I'll be happy to proceed with merging.
|
Apologies for the bump, but has the author had time to resolve the requested changes? This is a feature we'd be very happy to have ourselves for our project. |
|
@FatCatClient feel free to restart with a new PR for this (and verify by testing locally!). Not sure if this PR will be continued and I'm unable to push changes to it |
… create shortcuts)
allows the user to configure wether or not they wish to create shortcuts after finishing installation