Skip to content

Conversation

@jaywalker15262
Copy link

… create shortcuts)

allows the user to configure wether or not they wish to create shortcuts after finishing installation

… create shortcuts)

allows the user to configure wether or not they wish to create shortcuts after finishing installation
@changeset-bot
Copy link

changeset-bot bot commented May 22, 2025

🦋 Changeset detected

Latest commit: a461ca2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

[Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/jaywalker15262/electron-builder/new/master?filename=.changeset/odd-bees-grin.md&value=---%0A%22app-builder-lib%22%3A%20patch%0A---%0A%0Afeat%3A%20add%20nsis%20support%20for%20allowToAddShortcuts(user%20decides%20wether%20to%E2%80%A6%0A)

* If enabled, the user can opt-in or opt-out at install time.
* @default false
*/
readonly allowToAddShortcut?: boolean
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on renaming this to allowToCustomizeShortcuts since it supports customizing desktop and/or start menu. Thinking "Customize" because it allows the user to allow/enable or disable/remove shortcuts from being created.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not, good idea

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaywalker15262 I am unable to push changes to this PR to update the property. Can you please attend to this and I'll be happy to proceed with merging.

@FatCatClient
Copy link

Apologies for the bump, but has the author had time to resolve the requested changes? This is a feature we'd be very happy to have ourselves for our project.

@mmaietta
Copy link
Collaborator

mmaietta commented Oct 1, 2025

@FatCatClient feel free to restart with a new PR for this (and verify by testing locally!). Not sure if this PR will be continued and I'm unable to push changes to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants