Skip to content

fix: wrap CN in quotes #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: wrap CN in quotes #17

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c52505a
fix: wrap CN in quotes
MarshallOfSound Oct 10, 2025
a58c443
build: pin
MarshallOfSound Oct 10, 2025
01c23de
Merge branch 'main' into sam/quote-pub
erickzhao Nov 5, 2025
73e8587
fix unit test
erickzhao Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/e2e_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0

- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: '22'

Expand All @@ -29,7 +29,7 @@ jobs:
run: yarn test:e2e:coverage

- name: Upload coverage report
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: coverage-report
path: coverage
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0

- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: '22'

Expand All @@ -29,7 +29,7 @@ jobs:
run: yarn test:unit:coverage

- name: Upload coverage report
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: coverage-report
path: coverage
Expand Down
2 changes: 1 addition & 1 deletion static/templates/AppxManifest.xml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<Identity Name="{{IdentityName}}"
ProcessorArchitecture="{{ProcessorArchitecture}}"
Version="{{Version}}"
Publisher="CN={{PublisherName}}"/>
Publisher="CN=&quot;{{PublisherName}}&quot;"/>
<Properties>
<DisplayName>{{DisplayName}}</DisplayName>
<PublisherDisplayName>{{PublisherDisplayName}}</PublisherDisplayName>
Expand Down
Loading