Skip to content

ci: get PR approver app token from secret service #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

ci: get PR approver app token from secret service #258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dafc098
ci: get PR approver app token from secret service
dsanders11 Nov 17, 2025
24f6cac
chore: add missing permission
dsanders11 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/update-abi.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
- 3-x-y
runs-on: ubuntu-latest
environment: auto-updater
permissions:
id-token: write # for secret service access
steps:
- name: Generate GitHub App token (updater app)
uses: electron/github-app-auth-action@384fd19694fe7b6dcc9a684746c6976ad78228ae # v1.1.1
Expand Down Expand Up @@ -54,17 +56,15 @@ jobs:
--body "Automated PR to update abi_registry.json" \
--head "feat/update-abi-registry-${{ matrix.branch }}-${{ hashFiles('abi_registry.json') }}" \
--base ${{ matrix.branch }}
- name: Generate GitHub App token (approver app)
uses: electron/github-app-auth-action@384fd19694fe7b6dcc9a684746c6976ad78228ae # v1.1.1
- name: Get GitHub App token (approver app)
if: ${{ steps.commit-changes.outputs.sha }}
id: generate-token-approver
with:
creds: ${{ secrets.APPROVER_GH_APP_CREDS }}
id: secret-service
uses: electron/secret-service-action@3476425e8b30555aac15b1b7096938e254b0e155 # v1.0.0
- name: Approve and merge pull request
if: ${{ steps.commit-changes.outputs.sha }}
shell: bash
env:
GITHUB_TOKEN: ${{ steps.generate-token-approver.outputs.token }}
GITHUB_TOKEN: ${{ fromJSON(steps.secret-service.outputs.secrets).PR_APPROVER_GH_TOKEN }}
run: |
set -eo pipefail
gh pr review "feat/update-abi-registry-${{ matrix.branch }}-${{ hashFiles('abi_registry.json') }}" --approve
Expand Down