Skip to content

Conversation

@byteplow
Copy link

@byteplow byteplow commented Oct 29, 2025

Adds tooltip New conversation to Compose Menu Button In Room List Header.

Screenshot from 2025-10-29 16-38-04

Checklist


const MenuTrigger = ({ ref, ...props }: MenuTriggerProps): JSX.Element => (
<Tooltip label={_t("action|start_chat")}>
<IconButton aria-label={_t("action|add")} {...props} ref={ref}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the aria-label is overwritten by the label of the parent Tooltip, causing your tests to fail. I believe this uses Add because the menu also lets you create rooms so Start chat would be a misleading tooltip for that

Image

Also there should probably be a tooltip consistently between the Start chat single-button variant of this button and the menu-trigger "Add" variant

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose 'Start chat' because 'Add' did not seem clear to me. ("Add what?") I assumed that a room was also a chat (group chat). I see that this is misleading in terms of the element naming convention. Especially if the button also allows to create a video room. Would 'Add room' fit the element naming convention? A chat is also a room. I guess our users could understand that. Otherwise, I will try to come up with a better tooltip or just use 'Add'.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would 'Add room' fit the element naming convention?

It'd fit within the Matrix naming convention but I think Design would not be happy as they definitely do not want DMs to be seen as rooms, so that would definitely need design sign-off which can take a while to get.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New conversation? "Conversation" is alrady being used in some places for room and dms. e.g:

  • "Start a conversation with someone using their name or username (like <userId/>)."
  • "Recent Conversations"
  • "Own your conversations."

@florianduros
Copy link
Member

@byteplow the PR has lint errors, you can run yarn lint to list them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Enhancement Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants