Playwright test: withheld sessions for MSC4268 #31153
Conversation
Test what happens when a session is withheld as part of MSC4268
richvdh
force-pushed
the
rav/history_sharing/withheld_session_test
branch
from
aa46c1e to
12c2701
Compare
| * Opens the room info panel if it is not already open. | ||
| * | ||
| * @returns locator to the right panel | ||
| */ | ||
| public async openRoomInfoPanel(): Promise<Locator> { | ||
| const locator = this.page.getByTestId("right-panel"); | ||
| if (!(await locator.isVisible())) { | ||
| await this.page.getByRole("button", { name: "Room info" }).first().click(); | ||
| } | ||
| return locator; | ||
| } |
There was a problem hiding this comment.
Seems like this would unexpectedly no-op if say the member list was open instead of the room info panel?
There was a problem hiding this comment.
probably. It works for my usecase, and is a material improvement on what was there before. I'm disinclined to spend too long gold-plating it.
There was a problem hiding this comment.
Can that footgun be included in the comment then?
There was a problem hiding this comment.
I've added a TODO which will hopefully get the idea across.
There was a problem hiding this comment.
I've added a TODO which will hopefully get the idea across.
Fine by me, it seems clear that this method won't do anything in that context. Although if you're not planning to fix it in this PR, maybe drop the TODO and say that's the intended behaviour? Either is fine, I think.
There was a problem hiding this comment.
I wouldn't say it's "intended behaviour": it's my hope/expectation that someone will need this functionality at some point and fix it.
There was a problem hiding this comment.
LGTM! For others in the comments, the CI failure is an unrelated flaky test.
Test what happens when a session is withheld as part of MSC4268
(Per element-hq/element-meta#2876 (comment), it should say "you don't have access to this message").