Fix crash when calling Room.predecessorRoom when the room is destroyed
#5894
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5894 +/- ##
===========================================
- Coverage 81.38% 81.38% -0.01%
===========================================
Files 2479 2479
Lines 66200 66202 +2
Branches 8431 8433 +2
===========================================
+ Hits 53876 53877 +1
- Misses 9221 9223 +2
+ Partials 3103 3102 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Actually, the root cause of this issue seems to be activity recreation causing the |
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Thanks for the fix! 2 non-blocking questions
| override val graph = roomGraphFactory.create(inputs.room) | ||
|
|
||
| // This is an ugly hack to check activity recreation | ||
| private val currentActivity = mutableStateOf<Activity?>(null) |
There was a problem hiding this comment.
Does it need to be a MutableState? Can't it just be of type Activity?? (like in LoginFlowNode for instance)
There was a problem hiding this comment.
I'd need to double check if this could affect the stability of the composable. Since we're only assigning the value, maybe it won't.
There was a problem hiding this comment.
It seems to be fine:
restartable skippable open scheme("[androidx.compose.ui.UiComposable]") fun io.element.android.appnav.room.joined.JoinedRoomLoadedFlowNode.View(
unused stable modifier: Modifier
stable <this>: JoinedRoomLoadedFlowNode
)
| if (currentActivity.value?.isChangingConfigurations != true) { | ||
| activeRoomsHolder.removeRoom(inputs.room.sessionId, inputs.room.roomId) | ||
| inputs.room.destroy() | ||
| } |
There was a problem hiding this comment.
Maybe also reset the value of currentActivity?
jmartinesp
force-pushed
the
fix/fix-crash-when-calling-predecessorroom-from-timelinepresenter
branch
from
746f49a to
9012160
Compare
jmartinesp
force-pushed
the
fix/fix-crash-when-calling-predecessorroom-from-timelinepresenter
branch
from
9012160 to
4ac2322
Compare
|
Content
What the title says.
Motivation and context
Fix a crash observed in the wild, when there is an activity recreation with a room opened:
Tests
With a room open, cause an activity recreation. This can be quickly done with a foldable emulator or device by folding/unfolding the device.
Tested devices
Checklist