Skip to content

Conversation

@anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Nov 4, 2025

This was prompted by #19132 being caught after the fact, rather than during review of #19055.

This adds two extra CI runs to each PR, with the benefit of catching places where we may introduce code that's incompatible with the latest Python version (but is compatible with the oldest).

To reduce the cost, we may want to only run the postgres Python 3.14 trial CI job on PRs, instead of both sqlite and postgres. This is because more tests are run on the postgres variant. Either the sqlite or postgres variant would have caught #19132.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@anoadragon453 anoadragon453 marked this pull request as ready for review November 4, 2025 12:15
@anoadragon453 anoadragon453 requested a review from a team as a code owner November 4, 2025 12:15
Comment on lines +38 to +41
# For PRs, we only run each type of test with the oldest and newest Python
# version that's supported. The oldest version ensures we don't accidentally
# introduce syntax or code that's too new, and the newest ensures we don't use
# code that's been dropped in the latest supported Python version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 mint!

@anoadragon453 anoadragon453 enabled auto-merge (squash) November 10, 2025 17:10
@anoadragon453 anoadragon453 merged commit 2c91896 into develop Nov 12, 2025
43 of 45 checks passed
@anoadragon453 anoadragon453 deleted the anoa/run_py_3_14_tests_on_prs branch November 12, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants