Skip to content

Conversation

@sgfn
Copy link
Member

@sgfn sgfn commented Jul 2, 2025

Moved from #35

@sgfn sgfn requested a review from mickel8 July 2, 2025 15:25
@sgfn sgfn force-pushed the sgfn/av1-payloader branch from 92e0893 to 018019a Compare July 2, 2025 15:27
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.78%. Comparing base (5e20c3d) to head (35db6f2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/rtp/av1/obu.ex 96.29% 1 Missing ⚠️
lib/ex_webrtc/rtp/av1/payloader.ex 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   87.70%   87.78%   +0.08%     
==========================================
  Files          50       54       +4     
  Lines        2684     2743      +59     
==========================================
+ Hits         2354     2408      +54     
- Misses        330      335       +5     
Files with missing lines Coverage Δ
lib/ex_webrtc/rtp/av1/leb128.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp/av1/payload.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp/payloader.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp/vp8/payloader.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/utils.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp/av1/obu.ex 96.29% <96.29%> (ø)
lib/ex_webrtc/rtp/av1/payloader.ex 92.85% <92.85%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e20c3d...35db6f2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mickel8 mickel8 mentioned this pull request Jul 3, 2025
Copy link
Contributor

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@sgfn sgfn merged commit e339453 into master Jul 3, 2025
3 checks passed
@sgfn sgfn deleted the sgfn/av1-payloader branch July 3, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants