Fix single number in hour and minute #47
Conversation
juanjecilla
force-pushed
the
fix/hour_format
branch
2 times, most recently
from
c9fc263 to
1285bfc
Compare
| internal fun provideHttpLoggingInterceptor(): HttpLoggingInterceptor = | ||
| HttpLoggingInterceptor().apply { | ||
| level = HttpLoggingInterceptor.Level.HEADERS | ||
| level = HttpLoggingInterceptor.Level.BODY |
There was a problem hiding this comment.
can you revert this change?
There was a problem hiding this comment.
What do you think about keeping BODY but only for debug?
| } | ||
|
|
||
| @Test | ||
| fun `toUI handles malformed time strings gracefully`() { |
There was a problem hiding this comment.
maybe we should rename this test, I see that is simply returning those time slots that were formatted correctly and not returning those with errors. maybe: toUI returns only properly formatted time slot times
There was a problem hiding this comment.
Let's rename it then,
| import org.junit.Assert.assertNull | ||
| import org.junit.Test | ||
|
|
||
| internal class AdditionalCostMapperTest { |
There was a problem hiding this comment.
most of the tests here are testing the time slot formatting, wasn't this tests more related to the String.hoursAndMinutesText extension than the AdditionalCosts.kt model?
There was a problem hiding this comment.
Yes, the problem was in the extension but with these tests, we are covering more use cases.
juanjecilla
force-pushed
the
fix/hour_format
branch
from
1285bfc to
2d78bad
Compare
No description provided.